Skip to content

London|26-ITP-January|Alexandru Pocovnicu|Sprint 3 |dead code#944

Open
alexandru-pocovnicu wants to merge 3 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu:coursework/sprint-3-dead-code
Open

London|26-ITP-January|Alexandru Pocovnicu|Sprint 3 |dead code#944
alexandru-pocovnicu wants to merge 3 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu:coursework/sprint-3-dead-code

Conversation

@alexandru-pocovnicu
Copy link

@alexandru-pocovnicu alexandru-pocovnicu commented Feb 9, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Deleted unnecessary code for better readability

@alexandru-pocovnicu alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 9, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment on lines +17 to +18
//it isn't very clear if I should change the way greeting is declared from "const"
//to "let" so that any greeting can be used not just "hello" No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ok. The objective of this exercise is just to remove dead code.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants